Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete the cx4 in favor of a ruger PCC #73051

Closed
wants to merge 2 commits into from
Closed

Obsolete the cx4 in favor of a ruger PCC #73051

wants to merge 2 commits into from

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

I noticed the Cx4 Storm was below our cutoff for circulation, and statted up a more popular 9mm carbine to replace it (though that one falls into the same niche as the even more popular Kel Tec Sub200, so probably needn't have bothered.

Describe the solution

Add the Ruger 9mm PCC and migrate Cx4 storms to it.

Describe alternatives you've considered

Ehhhh?

Testing

Loaded up a character with a Cx4 and it turned into a PCC.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) labels Apr 16, 2024
github-actions[bot]
github-actions bot reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @I-am-Erk

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 16, 2024
@TheShadowFerret
Copy link
Contributor

Does this mean we'll get the P Series of pistols too 👉👈

@kevingranade
Copy link
Member Author

Looks like the P89 and P95 barely squeak by the gunbroker criteria.

@kevingranade kevingranade force-pushed the obsolete-ksub-cx4 branch 2 times, most recently from ee2a016 to d03d07e Compare April 17, 2024 00:33
@github-actions github-actions bot added [Python] Code made in Python Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Apr 17, 2024
github-actions[bot]
github-actions bot reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @jbytheway

@github-actions GitHub Actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Ruger 9mm pistol calibre carbine
  • Ruger 9mm pistol calibre carbines

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Apr 20, 2024
@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 25, 2024
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Jun 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jul 15, 2024
@Night-Pryanik
Copy link
Contributor

Is this salvageable in current form (after resolving conflicts)? Or is it better to start from the scratch due to many conflicts?

@kevingranade
Copy link
Member Author

It's almost certainly going to be easier to start over, that's some extensive conflicts and the amount of work to obsolete it in the first place wasn't that large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anothersimulacrum anothersimulacrum anothersimulacrum left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns Mods Issues related to mods or modding NPC / Factions NPCs, AI, Speech, Factions, Ownership [Python] Code made in Python Spawn Creatures, items, vehicles, locations appearing on map stale Closed for lack of activity, but still valid.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevingranade @TheShadowFerret @Night-Pryanik @anothersimulacrum @dseguin